Fix test resources properties factory #667
Merged
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the `TestResourcesPropertiesFactory`, which incorrectly passed the `testResourcesConfig` map. Instead of removing the `test-resources.` prefix, like the client expects, it was passing the full property name which led to resolvers being unable to resolve properties. While this commit fixes the problem at the source, in the properties factory, a sanity cleanup has been introduced in the controller, in order to cleanup such entries in case they show up. This could be useful if a program uses the client directly but forgets to do the same (in the "normal" use case, the properties are passed "naturally" without the prefix because that's how the config API works). Fixes #663
|
graemerocher
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
TestResourcesPropertiesFactory, which incorrectly passed thetestResourcesConfigmap. Instead of removing thetest-resources.prefix, like the client expects, it was passing the full property name which led to resolvers being unable to resolve properties.While this commit fixes the problem at the source, in the properties factory, a sanity cleanup has been introduced in the controller, in order to cleanup such entries in case they show up. This could be useful if a program uses the client directly but forgets to do the same (in the "normal" use case, the properties are passed "naturally" without the prefix because that's how the config API works).
Fixes #663
(Note to the reviewer: this only concerns users of the test resources JUnit extensions)